fix: make shiv install lock reentrant - #26
Merged
Conversation
|
I love this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MISE_JOBS=1into the delegatedshiv installcommand so package-local dependency installs can recurse without self-deadlockingBackendInstall -> delegated install -> nested with_lockshapeWhy
Fold CI and Brownie dispatch are blocked before tests/agent start on
mise installwith repeated nested failures like:Root cause: vfox-shiv serializes the delegated
shiv installphase, butshiv installmay run package-localmise installfor dependencies. If those dependencies includeshiv:*tools, the nested vfox-shiv invocation waits on the same lock held by its ancestor until timeout.This keeps the lock for unrelated/concurrent top-level installs, while allowing descendants that inherit the matching owner token to reenter.
Validation
mise run test luamise run test bootstrap_dependenciesshiv:emails@0.6.2fails with the lock timeout; this branch linked as the shiv plugin succeeds withMISE_JOBS=1andVFOX_SHIV_INSTALL_LOCK_MAX_ATTEMPTS=3git diff --checkmise run test(82/82)Notes
VFOX_SHIV_INSTALL_LOCK_OWNERis not a security boundary. It is an advisory token to distinguish descendant nested installs from unrelated installs in the same mise data dir.